fix(ci): add concurrency group to cancel superseded runs on force-push#444
Merged
fix(ci): add concurrency group to cancel superseded runs on force-push#444
Conversation
Force-pushes triggered a new pull_request synchronize event while the previous run's lightweight jobs (conventional-commits, IPR) still held the free-tier runner slots. The 4-runner Test Python matrix for the new SHA was queued but never scheduled — the fast jobs always won. Required a manual close/reopen to retrigger. The concurrency block cancels in-progress runs for the same ref so the new SHA's matrix jobs get scheduled immediately. Closes #413
bokelley
added a commit
that referenced
this pull request
May 3, 2026
Bring the branch up to date with main (PRs #441, #444, #445, #446, #447). Conflicts resolved: * ``.github/workflows/ci.yml`` — keep main's restructured v3 storyboard job (translator-pattern upstream mock + readiness loop) and apply the poll-fix pattern (``||`` outside command substitution) to both the upstream-mock readiness loop and main's new seller-readiness loop. * ``src/adcp/server/serve.py`` — combine main's strict-by-default ``validation=DEFAULT_VALIDATION`` flip with the three transport- security kwargs added on this branch (``allowed_hosts``, ``allowed_origins``, ``enable_dns_rebinding_protection``). Auto-merged: ``examples/v3_reference_seller/src/app.py`` (translator rewrite + this branch's webhook/dispose/DNS-rebinding kwargs), ``examples/v3_reference_seller/tests/test_smoke.py`` (translator rewrite + this branch's port-stripping regression test), ``src/adcp/server/mcp_tools.py`` (lazy schema gen + this branch's ``setdefault("type", "object")`` for union outputSchemas), ``examples/seller_agent.py`` (channels filter intact).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #413. Force-pushes did not retrigger the Test Python matrix because the previous run's lightweight jobs (conventional-commits, IPR) still held the free-tier runner slots; the matrix for the new SHA was queued but never scheduled. Required `gh pr close && gh pr reopen` to work around.
This adds a per-ref concurrency group with `cancel-in-progress: true`, so a new `synchronize` event cancels the superseded run and frees the runner slots immediately.
Test plan
🤖 Generated with Claude Code